Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add params to metadata action to fix multi IdPs issue #175

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

luke-zhou
Copy link
Contributor

For issue #173, support metadata for multiple IdPs

@adamstegman adamstegman merged commit 1bf5a50 into apokalipto:master Aug 6, 2020
@samgreen96
Copy link

In regards to this change would it be worth going one step further and leveraging the exisiting get_idp_entity_id(params) method in place of params[:idp_entity_id] for the use case where someone has implemented their own idp_entity_reader class?

Sorry to comment on a closed issue - and thanks very much for making this gem :)

@adamstegman
Copy link
Collaborator

@samgreen96 it would definitely be nice! Unfortunately the default entity ID reader depends on the presence of a SAML payload—I think it would make sense to enhance it to look for the presence of an idp_entity_id query parameter if you want to adjust that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants