Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass controller request object to idp settings adapter #218

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Pass controller request object to idp settings adapter #218

merged 2 commits into from
Feb 22, 2022

Conversation

tedkeep
Copy link
Contributor

@tedkeep tedkeep commented Feb 18, 2022

In applications where the domain name can change, the use of the ActionController request object is required so the SP url can be set dynamically.

This change makes it so the request object can optionally be passed to the IdPSettingsAdapter#settings method so urls can be created dynamically.

Copy link
Collaborator

@adamstegman adamstegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition! Now I wish we'd used a hash instead of positional arguments 🙂

@adamstegman adamstegman merged commit 617e790 into apokalipto:master Feb 22, 2022
@tedkeep tedkeep deleted the pass_request_to_idp_settings_adapter branch March 21, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants