Update ReleaseMessageServiceWithCacheTest.java #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the flaky test.
nobodyiam
reviewed
Apr 16, 2022
...ava/com/ctrip/framework/apollo/configservice/service/ReleaseMessageServiceWithCacheTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4314 +/- ##
=========================================
Coverage 53.17% 53.17%
Complexity 2668 2668
=========================================
Files 488 488
Lines 15253 15253
Branches 1577 1577
=========================================
Hits 8111 8111
Misses 6587 6587
Partials 555 555 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
testWhenReleaseMsgSizeBiggerThan500in classReleaseMessageServiceWithCacheTestis flaky due to the iteration of hashset used in methodfindLatestReleaseMessagesGroupByMessagesin classReleaseMessageServiceWithCache. It may occasionally fail in different JVM's or in different Java versions.I modify the test so this test won't be affect by the flakiness of indeterministic order of iteration of hashset.
reproduce:
mvn -pl apollo-configservice edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=ReleaseMessageServiceWithCacheTest#testWhenReleaseMsgSizeBiggerThan500 -DnondexRuns=10