Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing as npm module #160

Closed
Gongreg opened this issue Dec 21, 2018 · 10 comments
Closed

Publishing as npm module #160

Gongreg opened this issue Dec 21, 2018 · 10 comments
Assignees

Comments

@Gongreg
Copy link
Contributor

Gongreg commented Dec 21, 2018

Hello, I would like to know, would it be possible to publish apollo-dev-tools as a npm module so it could be included as a dependency in react-native-debugger? We need to use some code (backend code of apollo devtools) inside the debugger itself, to support apollo dev tools for react-native.

A slightly offtopic question, but maybe you know what exactly the UUID is used here for? https://github.com/apollographql/apollo-client-devtools/blob/dc0d97f42e1223ea80e464bdc7aa518006a23c07/src/backend/checkVersions.js

I am having issues with this part of code since it uses localStorage, but localStorage is not available inside webworkers (react native runs in webworker).

Also here is PR for implementing apollo dev tools for react native. jhen0409/react-native-debugger#298

@danilobuerger
Copy link

@hwillson could you take a look at this please so we can finally get react-native dev tool support working? It should be easy to publish this?

@Gongreg
Copy link
Contributor Author

Gongreg commented Dec 23, 2018

It is holidays season now :) Lets hope to release it in beginning of January :)

@hwillson
Copy link
Member

Thanks for heading up this initiative @Gongreg! We should be able to do this. The Apollo team is a bit light this week due to the holidays, but I've flagged this for discussion when everyone gets back next week.

@hwillson hwillson self-assigned this Dec 26, 2018
@Gongreg
Copy link
Contributor Author

Gongreg commented Jan 5, 2019

Hey @hwillson,
Maybe you have any news?

@Gongreg
Copy link
Contributor Author

Gongreg commented Jan 9, 2019

Hey @hwillson, I would really like to move this forward.
I saw a lot of positive feedback from community, the sooner we release it the better :)

@Gongreg
Copy link
Contributor Author

Gongreg commented Jan 17, 2019

Hello @hwillson,
Writing as a reminder. Is there anything I can do to help?

@hwillson
Copy link
Member

Hi @Gongreg - we're transitioning repo management responsibilities a bit internally. @cheapsteak and @justinanastos are going to help get outstanding devtools issues under control, PR's reviewed/merged, and work on improving devtools as a whole. Both this request and your great PR #165 will be reviewed shortly. Thanks!

@cheapsteak
Copy link
Member

Apologies for the delay
It's published now at https://www.npmjs.com/package/apollo-client-devtools

I'm not sure what the uuid is used for
Would you be able to work around it by stubbing out localStorage.get and .set as no-ops to unblock?
We could add a guard in the code here as well, not sure what a good process might be to determine whether it makes more sense to do that vs on the consumer's end

@Gongreg
Copy link
Contributor Author

Gongreg commented Jan 24, 2019

Hey, @cheapsteak
Regarding uuid everything is already solved in the PR I’ve created. It is referenced inside this issue.

@Gongreg
Copy link
Contributor Author

Gongreg commented Jan 25, 2019

Since it is published I am closing the issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants