Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type-import lint rule #1264

Merged
merged 3 commits into from
Mar 12, 2024
Merged

add type-import lint rule #1264

merged 3 commits into from
Mar 12, 2024

Conversation

phryneas
Copy link
Member

This should make it a bit more difficult for accidental bundle explosions like the one in #1262 to happen.

@phryneas phryneas requested a review from a team as a code owner March 12, 2024 13:16
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link

relativeci bot commented Mar 12, 2024

Job #2: Bundle Size — 1.08MiB (0%).

8c3532e(current) vs df5300f main#1(baseline)

Warning

Bundle contains 5 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #2
     Baseline
Job #1
No change  Initial JS 1.04MiB 1.04MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 5 5
No change  Assets 12 12
No change  Modules 486 486
No change  Duplicate Modules 32 32
No change  Duplicate Code 7.42% 7.42%
No change  Packages 59 59
No change  Duplicate Packages 4 4
Bundle size by type  no changes
                 Current
Job #2
     Baseline
Job #1
Not changed  JS 1.04MiB 1.04MiB
Not changed  IMG 35.85KiB 35.85KiB
Not changed  HTML 810B 810B
Not changed  Other 777B 777B

View job #2 reportView pr/type-import-eslint branch activityView project dashboard

@jerelmiller jerelmiller merged commit 66c05ae into main Mar 12, 2024
8 checks passed
@jerelmiller jerelmiller deleted the pr/type-import-eslint branch March 12, 2024 14:57
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants