fixup errorcodes workflow #1313
Conversation
| @@ -21,7 +21,7 @@ jobs: | |||
| echo "No new error codes were added." | |||
| exit 0 | |||
| fi | |||
| cat <<EOF > ../.changeset/`md5 < errorcodes.json`.md | |||
| cat <<EOF > ../.changeset/errorcodes.md | |||
There was a problem hiding this comment.
I believe it should be fine to always use the same name here, right @alessbell?
There was a problem hiding this comment.
Generally yes if we can assume there would only ever be one PR with an errorcodes.md open at a time, but if you ever introduce a prerelease workflow I'd change this so the file name is unique.
There was a problem hiding this comment.
Then let's revisit this if we ever get to the point of doing prereleases with the devtools ^^
There was a problem hiding this comment.
As for the "ever only one" part - since they will all have the same message, it's probably even better that we don't repeat that over and over in the case of multiple PRs - it's not really important for the release message to know if error messages were updated once or three times between releases ^^
.mdis not a good filename for a changeset 馃槄