Schedule next request to get data after previous request finishes #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#298 Bundle Size — 889.98KiB (0%).Warning Bundle contains 31 duplicate packages – View duplicate packages Bundle metrics
|
| Current #298 |
Baseline #294 |
|
|---|---|---|
 Initial JS |
852.58KiB |
852.58KiB |
| Initial CSS |
0B |
0B |
 Cache Invalidation |
0% |
86.91% |
| Chunks |
5 |
5 |
| Assets |
12 |
12 |
| Modules |
680 |
680 |
| Duplicate Modules |
35 |
35 |
| Duplicate Code |
4.72% |
4.72% |
| Packages |
96 |
96 |
| Duplicate Packages |
30 |
30 |
Bundle size by type no changes
| Current #298 |
Baseline #294 |
|
|---|---|---|
| JS |
852.58KiB |
852.58KiB |
| IMG |
35.85KiB |
35.85KiB |
| HTML |
810B |
810B |
| Other |
778B |
778B |
Bundle analysis report Branch jerel/request-interval Project dashboard
phryneas
reviewed
May 6, 2024
src/extension/devtools/devtools.ts
Outdated
| @@ -98,14 +98,15 @@ function startRequestInterval(ms = 500) { | |||
| payload: await rpcClient.request("getClientOperations"), | |||
| }); | |||
| } | |||
|
|
|||
| id = setTimeout(() => getClientData(), ms); | |||
There was a problem hiding this comment.
Suggested change
| id = setTimeout(() => getClientData(), ms); | |
| id = setTimeout(getClientData, ms); |
I think we don't need the function definition here
There was a problem hiding this comment.
Also, should we wrap the whole block in try..finally to ensure an exception doesn't break the loop?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization to only trigger a new fetch of data after the previous completes. In case we are dealing with large payloads that take a significant amount of time to copy over, this prevents us from potentially overlapping the next request before the previous finishes.