Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change list styles to make the text a bit smaller #1360

Merged
merged 2 commits into from
May 8, 2024

Conversation

jerelmiller
Copy link
Member

#1349 updated the list styles to better match the styles we have for lists in Studio UI. We had some feedback that this was a bit too large (and I agree) so this PR reverts the change to make the text a bit smaller. We are naturally working with less screen real estate, so the more we can fit in the view, the better.

Before
Screenshot 2024-05-08 at 4 10 39 PM

After
Screenshot 2024-05-08 at 4 10 19 PM

@jerelmiller jerelmiller requested a review from a team as a code owner May 8, 2024 22:11
Copy link

relativeci bot commented May 8, 2024

#320 Bundle Size — 913.8KiB (0%).

d13c664(current) vs c235251 main#317(baseline)

Warning

Bundle contains 32 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#320
     Baseline
#317
No change  Initial JS 876.4KiB 876.4KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 5 5
No change  Assets 12 12
No change  Modules 683 683
No change  Duplicate Modules 35 35
No change  Duplicate Code 4.56% 4.56%
No change  Packages 99 99
No change  Duplicate Packages 31 31
Bundle size by type  no changes
                 Current
#320
     Baseline
#317
No change  JS 876.4KiB 876.4KiB
No change  IMG 35.85KiB 35.85KiB
No change  HTML 810B 810B
No change  Other 778B 778B

Bundle analysis reportBranch jerel/revert-list-stylesProject dashboard

@jerelmiller jerelmiller merged commit e922d83 into main May 8, 2024
9 checks passed
@jerelmiller jerelmiller deleted the jerel/revert-list-styles branch May 8, 2024 22:13
@github-actions github-actions bot mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant