Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some design elements based on latest orbit designs #1349

Merged
merged 27 commits into from
May 6, 2024

Conversation

jerelmiller
Copy link
Member

Includes some fixes for incorrect design elements in the existing components.

@jerelmiller jerelmiller requested a review from a team as a code owner May 4, 2024 04:47
Copy link

relativeci bot commented May 4, 2024

#302 Bundle Size — 913.79KiB (+2.68%).

a3d79b7(current) vs 2761ff3 main#299(baseline)

Important

Bundle introduced 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 2 new packages: tailwind-merge, class-variance-authority – View changed packages

Bundle metrics  Change 6 changes Regression 3 regressions
                 Current
#302
     Baseline
#299
Regression  Initial JS 876.39KiB(+2.79%) 852.58KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 87.63% 0%
No change  Chunks 5 5
No change  Assets 12 12
Change  Modules 683(+0.44%) 680
No change  Duplicate Modules 35 35
Change  Duplicate Code 4.56%(-3.39%) 4.72%
Regression  Packages 99(+3.13%) 96
Regression  Duplicate Packages 31(+3.33%) 30
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#302
     Baseline
#299
Regression  JS 876.39KiB (+2.79%) 852.58KiB
No change  IMG 35.85KiB 35.85KiB
No change  HTML 810B 810B
No change  Other 778B 778B

Bundle analysis reportBranch jerel/design-updatesProject dashboard

Base automatically changed from jerel/bug-button to main May 6, 2024 14:53
@jerelmiller
Copy link
Member Author

Got a verbal approval from @phryneas for this PR 🙂

@jerelmiller jerelmiller merged commit 06a0b5a into main May 6, 2024
9 checks passed
@jerelmiller jerelmiller deleted the jerel/design-updates branch May 6, 2024 16:23
@github-actions github-actions bot mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant