Update client not found modal to make creating an issue more prominent #1426
Conversation
#611 Bundle Size — 1.28MiB (+0.03%).Warning Bundle contains 13 duplicate packages – View duplicate packages Bundle metrics
|
| Current #611 |
Baseline #609 |
|
|---|---|---|
 Initial JS |
1.24MiB(+0.03%) |
1.24MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
91.28% |
97.11% |
| Chunks |
5 |
5 |
| Assets |
12 |
12 |
| Modules |
1028(+0.1%) |
1027 |
| Duplicate Modules |
49 |
49 |
| Duplicate Code |
3.94% |
3.94% |
| Packages |
162 |
162 |
| Duplicate Packages |
10 |
10 |
Bundle size by type 1 change 1 regression
| Current #611 |
Baseline #609 |
|
|---|---|---|
| JS |
1.24MiB (+0.03%) |
1.24MiB |
| IMG |
35.85KiB |
35.85KiB |
| HTML |
810B |
810B |
| Other |
778B |
778B |
Bundle analysis report Branch jerel/update-modal-messaging Project dashboard
|
Hmm, the "reached in error" now repeats and reads a bit contradictory for me. I don't have better wordings suggestions, though. |
|
Ha thank you. You're totally right. I'll noodle on this a bit more. Thank you! |
| </Modal.Header> | ||
| <Modal.Body> | ||
| <p> | ||
| <Modal.Description> | ||
| An Apollo Client instance was not found, either because an Apollo | ||
| Client instance was never created, or because it could not be | ||
| discovered. This is most commonly fixed by setting the{" "} |
There was a problem hiding this comment.
Suggestion to
- Use active voice to give ownership of the issue to the user
- Refer to "this" as "this issue" to establish what "this" is. We can substitute "error" for "issue" if that is more accurate.
| discovered. This is most commonly fixed by setting the{" "} | |
| discovered. You can often solve this issue by setting {" "} |
| </Modal.Header> | ||
| <Modal.Body> | ||
| <p> | ||
| <Modal.Description> | ||
| An Apollo Client instance was not found, either because an Apollo | ||
| Client instance was never created, or because it could not be | ||
| discovered. This is most commonly fixed by setting the{" "} | ||
| <ConnectToDevToolsOptionLink /> to <code>true</code>. |
There was a problem hiding this comment.
Though it's in the ConnectToDevToolsOptionLink link once they open it, it can be helpful to give context about where this option lives.
| <ConnectToDevToolsOptionLink /> to <code>true</code>. | |
| <ConnectToDevToolsOptionLink /> in your <code>ApolloClientOptions</code> to <code>true</code>. |
| If this was reached in error, please try one of the following | ||
| suggestions or click the "Retry" button to try looking for | ||
| the client again. |
There was a problem hiding this comment.
I think this is the flow we want to encourage? (Spacing might need to be fixed.)
Per our style guide, we use <strong> for text that appears in UIs.
| If this was reached in error, please try one of the following | |
| suggestions or click the "Retry" button to try looking for | |
| the client again. | |
| If you've already set <ConnectToDevToolsOptionLink /> to <code>true</code>, please try one of the following | |
| suggestions or click the <strong>Retry</strong> button to try looking for | |
| the client again. |
| > | ||
| create an issue | ||
| </GitHubIssueLink>{" "} | ||
| if you believe you have reached this in error. |
There was a problem hiding this comment.
Specify what "this" is. Use the same term, whether "issue," "error," or something else, as the first suggestion.
| if you believe you have reached this in error. | |
| if you believe you received this issue by mistake. |
There was a problem hiding this comment.
Thanks for the help! Added a bit more verbosity here to really make it clear. f841d58
Updates the client not found modal to link to creating a GitHub issue more prominent.