Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #1427

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Update deps #1427

merged 11 commits into from
Jun 25, 2024

Conversation

jerelmiller
Copy link
Member

Supersedes #1411
Supersedes #1366
Supersedes #1320

Manually updates some dependencies that renovate is trying to upgrade but fails. I'm ignoring the v2 update for react-resizable-panels for now because this is causing some test failures that require a bit more digging into.

@jerelmiller jerelmiller requested a review from a team as a code owner June 24, 2024 23:13
@@ -0,0 +1,3 @@
module.exports = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed by Jest in order to transform ESM libraries in tests

Copy link

relativeci bot commented Jun 24, 2024

#607 Bundle Size — 1.28MiB (+0.98%).

05bf74a(current) vs 9b60a1b main#592(baseline)

Important

Bundle introduced 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 4 new packages: lodash-es, @react-aria/focus, @react-aria/interactions and one more – View changed packages

Bundle metrics  Change 6 changes Regression 3 regressions
                 Current
#607
     Baseline
#592
Regression  Initial JS 1.24MiB(+1%) 1.23MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 97.11% 0%
No change  Chunks 5 5
No change  Assets 12 12
Change  Modules 1027(+7.99%) 951
No change  Duplicate Modules 49 49
Change  Duplicate Code 3.94%(-0.76%) 3.97%
Regression  Packages 162(+1.25%) 160
Regression  Duplicate Packages 10(+11.11%) 9
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#607
     Baseline
#592
Regression  JS 1.24MiB (+1%) 1.23MiB
No change  IMG 35.85KiB 35.85KiB
No change  HTML 810B 810B
No change  Other 778B 778B

Bundle analysis reportBranch jerel/update-depsProject dashboard

@@ -1,5 +1,31 @@
const esModules = [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a giant list because react-markdown includes a lot of ESM dependencies that need to be transformed. I wanted to use the real implementation rather than our mocked one, so this replaces our library mock that we had before. This was also needed because react-json-tree was updated to ESM-only in the latest release.

export default {
preset: "ts-jest",
preset: "ts-jest/presets/js-with-babel",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to transform .js files in node_modules to commonjs syntax in order for tests to run properly. The ts-jest preset on its own did not transform .js files, so our tests choked when importing from ESM libraries.

jest.config.js Outdated Show resolved Hide resolved
Co-authored-by: Lenz Weber-Tronic <mail@lenzw.de>
@jerelmiller
Copy link
Member Author

I'm not super happy with the bundle increase, but at least its on the devtools end. It looks like headless pulled in a bunch more dependencies with the v2 release. I may switch this over to radix at some point to keep everything within the same library, but that's outside the scope of this PR.

@jerelmiller jerelmiller merged commit 54d39bd into main Jun 25, 2024
9 checks passed
@jerelmiller jerelmiller deleted the jerel/update-deps branch June 25, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants