-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #1427
Update deps #1427
Conversation
@@ -0,0 +1,3 @@ | |||
module.exports = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed by Jest in order to transform ESM libraries in tests
#607 Bundle Size — 1.28MiB (+0.98%).Important Bundle introduced 1 duplicate package – View changed duplicate packages Warning Bundle introduced 4 new packages: lodash-es, @react-aria/focus, @react-aria/interactions and one more – View changed packages Bundle metrics
|
Current #607 |
Baseline #592 |
|
---|---|---|
Initial JS | 1.24MiB (+1% ) |
1.23MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 97.11% |
0% |
Chunks | 5 |
5 |
Assets | 12 |
12 |
Modules | 1027 (+7.99% ) |
951 |
Duplicate Modules | 49 |
49 |
Duplicate Code | 3.94% (-0.76% ) |
3.97% |
Packages | 162 (+1.25% ) |
160 |
Duplicate Packages | 10 (+11.11% ) |
9 |
Bundle size by type 1 change
1 regression
Current #607 |
Baseline #592 |
|
---|---|---|
JS | 1.24MiB (+1% ) |
1.23MiB |
IMG | 35.85KiB |
35.85KiB |
HTML | 810B |
810B |
Other | 778B |
778B |
Bundle analysis report Branch jerel/update-deps Project dashboard
@@ -1,5 +1,31 @@ | |||
const esModules = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a giant list because react-markdown
includes a lot of ESM dependencies that need to be transformed. I wanted to use the real implementation rather than our mocked one, so this replaces our library mock that we had before. This was also needed because react-json-tree
was updated to ESM-only in the latest release.
export default { | ||
preset: "ts-jest", | ||
preset: "ts-jest/presets/js-with-babel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed to transform .js
files in node_modules
to commonjs syntax in order for tests to run properly. The ts-jest
preset on its own did not transform .js
files, so our tests choked when importing from ESM libraries.
ef1b8a8
to
8f51dfa
Compare
Co-authored-by: Lenz Weber-Tronic <mail@lenzw.de>
I'm not super happy with the bundle increase, but at least its on the devtools end. It looks like headless pulled in a bunch more dependencies with the v2 release. I may switch this over to radix at some point to keep everything within the same library, but that's outside the scope of this PR. |
Supersedes #1411
Supersedes #1366
Supersedes #1320
Manually updates some dependencies that renovate is trying to upgrade but fails. I'm ignoring the v2 update for
react-resizable-panels
for now because this is causing some test failures that require a bit more digging into.