Use queryId as id for queries
#1438
Open
+17
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#652 Bundle Size — 1.29MiB (+0.8%).Warning Bundle contains 13 duplicate packages – View duplicate packages Bundle metrics
|
| Current #652 |
Baseline #644 |
|
|---|---|---|
 Initial JS |
1.25MiB(+0.82%) |
1.24MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
94.93% |
0% |
| Chunks |
5 |
5 |
| Assets |
12 |
12 |
| Modules |
1040(+1.17%) |
1028 |
| Duplicate Modules |
49 |
49 |
| Duplicate Code |
3.92%(-0.51%) |
3.94% |
| Packages |
162 |
162 |
| Duplicate Packages |
10 |
10 |
Bundle size by type 1 change 1 regression
| Current #652 |
Baseline #644 |
|
|---|---|---|
| JS |
1.25MiB (+0.82%) |
1.24MiB |
| IMG |
35.85KiB |
35.85KiB |
| HTML |
810B |
810B |
| Other |
778B |
778B |
Bundle analysis report Branch jerel/use-query-id Project dashboard
phryneas
reviewed
Jul 2, 2024
| @@ -46,6 +46,7 @@ export interface SerializedError { | |||
| } | |||
|
|
|||
| export type QueryInfo = { | |||
There was a problem hiding this comment.
Could we rename this type at some point? It's a bit of a red herring since we have a type of the same name over in AC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the value of
idused for queries to thequeryIdits associated with in Apollo Client rather than its index in the map. This should allow us to build additional functionality in the future that targets the proper query rather than guessing based on its index in the map.