Add deprecation messages to moved exports. #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#213 Bundle Size — 1.07MiB (+6.53%).Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
|
| Current #213 |
Baseline #189 |
|
|---|---|---|
 Initial JS |
938.93KiB(+5.31%) |
891.55KiB |
| Initial CSS |
70B(+100%) |
0B |
 Cache Invalidation |
85.99% |
0.04% |
| Chunks |
32(+33.33%) |
24 |
| Assets |
56(+24.44%) |
45 |
| Modules |
591(+15.43%) |
512 |
| Duplicate Modules |
110(+266.67%) |
30 |
| Duplicate Code |
7.61%(+489.92%) |
1.29% |
 Packages |
26(-10.34%) |
29 |
 Duplicate Packages |
1 |
1 |
Bundle size by type 3 changes 3 regressions
| Current #213 |
Baseline #189 |
|
|---|---|---|
| JS |
1.06MiB (+6.3%) |
1MiB |
| Other |
8.67KiB (+44.68%) |
5.99KiB |
| CSS |
70B (+100%) |
0B |
Bundle analysis report Branch pr/deprecate-moved-exports Project dashboard
jerelmiller
approved these changes
May 28, 2024
| > = _TransportedQueryRef<TData, TVariables>; | ||
| /** | ||
| * @deprecated | ||
| * Importing this hook from this package is not necessary anymore - you can directly import it from `@apollo/client`. |
There was a problem hiding this comment.
Suggested change
| * Importing this hook from this package is not necessary anymore - you can directly import it from `@apollo/client`. | |
| * Importing `useBackgroundQuery` from this package is no longer necessary. Import it directly from `@apollo/client` instead. |
[nit] I'd break this up into two sentences as I think it reads a bit better. Feel free to keep what you have though if you don't like this change, especially since this is just what you see in the editor. If you do like this, the other hook deprecations could also need this change to keep this consistent.
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.