Skip to content

Commit

Permalink
Set removeComments to false in tsconfig (#3086)
Browse files Browse the repository at this point in the history
We were previously setting this to true, which was stripping out test instructions for Istanbul and skewing our code coverage.

The comments should get removed anyway during minification, so this change should not affect bundle size.
  • Loading branch information
jamesmillerburgess authored and James Baxley committed Mar 23, 2018
1 parent cc7e4ad commit 3051219
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"noUnusedLocals": true,
"skipLibCheck": true,
"moduleResolution": "node",
"removeComments": true,
"removeComments": false,
"sourceMap": true,
"declaration": true,
"target": "es5",
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"moduleResolution": "node",
"declaration": true,
"noLib": true,
"allowSyntheticDefaultImports": true
"allowSyntheticDefaultImports": true,
"removeComments": false
}
}

0 comments on commit 3051219

Please sign in to comment.