Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links on apollo-client-3-migration doc #6102

Closed
chanonroy opened this issue Apr 1, 2020 · 3 comments
Closed

Broken links on apollo-client-3-migration doc #6102

chanonroy opened this issue Apr 1, 2020 · 3 comments

Comments

@chanonroy
Copy link

Intended outcome:

Clicking on internal doc links in the apollo-client-3-migration.md redirects us to the correct markdown document.

Example: Clicking on Configuring the cache should redirect us here.

Actual outcome:

A 404 page due to a missing .md on the end of the url.

How to reproduce the issue:

Visit apollo-client-3-migration.md, and click on Configuring the cache.

Likely has to due with the way that we are using relative links on markdown 🤔

Versions

@twavv
Copy link

twavv commented Apr 6, 2020

The documentation isn't meant to be read on GitHub. It is built and deployed to the Apollo docs site.

That page can be found (with working links) here: https://www.apollographql.com/docs/react/v3.0-beta/migrating/apollo-client-3-migration/

@chanonroy
Copy link
Author

Ah, gotcha! 👍

@hwillson
Copy link
Member

Answered in #6102 (comment) - thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants