docs: add TypedDocumentNode example #10031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpvajda
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
This change looks good to me, and is a nice addition so thanks for the contribution! I just want to get another set of eyes on the code sample to ensure it represents this functionality well. cc @hwillson @benjamn @alessbell @MrDoomBringer
benjamn
approved these changes
Oct 19, 2022
benjamn
force-pushed
the
hqd-typed-document-node
branch
from
b677907
to
8fd0880
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the "Using Apollo with TypeScript" documentation makes no mention of
TypeDocumentNode, which we consider a best practice. It would be nice to have somewhere to point to in the official docs.In this PR I borrowed an existing blurb from the CHANGELOG and adapted the "Typing hooks"
useQuery()example for my purposes.Thanks!