docs: fix React default import #10036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenBarlow
approved these changes
Aug 29, 2022
PowerKiKi
pushed a commit
to PowerKiKi/apollo-client
that referenced
this pull request
Aug 30, 2022
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I noticed. There is no named
Reactexport from theReactmodule. I think this code probably just works if you use enable "react-jsx" in the TS compiler or Babel "automatic" JSX runtime but in older code that usesReact.createElementthis would break sinceReactis undefined. Thanks!