remove obsolete displayName query option #10044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpvajda
reviewed
Sep 1, 2022
There was a problem hiding this comment.
Thanks for the contribution! I'm not 100% sure this change is something we want to do, looking at the docs for the use query API we seem to be saying this is an actual option available. Though I know this shared component is used in several sections of our docs so I'm going to check what is the actual functionality for UseQuery as you've also made some changes to the core API code.
jpvajda
added
🏓 awaiting-team-response
benjamn
force-pushed
the
hqd-displayName
branch
from
e2aa624
to
9cbe3f1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the docs I was confused by the
displayNameoption for theuseQuery()query hookSince
useQueryis a hook there is no component to set a display name to. I figured this was something that was carried over fromreact-apolloor was still used by Apollo Dev Tools or the legacy HOCs or components but from looking at the code it appears unused in those places.Let me know if I'm incorrect about any of this. Thanks!