Refetch should not return partial data with errorPolicy none #10321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
requested changes
Nov 30, 2022
🦋 Changeset detectedLatest commit: 7c16b85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alessbell
force-pushed
the
issue-10317-refetch-gets-partial-data-with-errorPolicy-none
branch
from
bf37255
to
7439e61
Compare
…none' of github.com:apollographql/apollo-client into issue-10317-refetch-gets-partial-data-with-errorPolicy-none
alessbell
commented
Jan 20, 2023
jerelmiller
reviewed
Jan 20, 2023
jerelmiller
deleted the
issue-10317-refetch-gets-partial-data-with-errorPolicy-none
branch
This was referenced Jan 20, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10317.
git bisectidentified 2d5e498 as the commit that introduced the regression.errorPolicy:'none'A quick recap of the default
errorPolicy:In the linked issue, two sibling components make two separate queries, where one query's selection set is included in the second query's. The bug is seen when one query fails with an error, but on
refetch(), the partial data in the cache is incorrectly rendered.Since the previous behavior was to indiscriminately unset
result.dataif thediff.complete || this.options.returnPartialDatacheck failed, this PR reinstates this behavior, but only whenerrorPolicyisnoneandnetworkStatusisrefetching.Checklist: