Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optimism 0.17.4 #10888

Merged
merged 8 commits into from May 17, 2023
Merged

Use optimism 0.17.4 #10888

merged 8 commits into from May 17, 2023

Conversation

alessbell
Copy link
Member

@alessbell alessbell commented May 17, 2023

Closes #10856.

Unblocks use of alphas/snapshot releases from branches targeting release-3.8 with Codesandbox - upstream workaround landed in optimism@0.17.4.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023

🦋 Changeset detected

Latest commit: 6b6d07b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alessbell alessbell changed the base branch from main to release-3.8 May 17, 2023 13:53
@alessbell alessbell requested review from phryneas and jerelmiller and removed request for StephenBarlow May 17, 2023 13:54
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 35.83 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 45.55 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.05 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.05 KB (0%)
import { useQuery } from "dist/react/index.js" 4.55 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.87 KB (0%)
import { useMutation } from "dist/react/index.js" 2.72 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.55 KB (0%)
import { useSuspenseQuery_experimental } from "dist/react/index.js" 3.72 KB (0%)
import { useBackgroundQuery_experimental } from "dist/react/index.js" 3.15 KB (0%)
import { useReadQuery_experimental } from "dist/react/index.js" 1.25 KB (0%)
import { useFragment_experimental } from "dist/react/index.js" 1.98 KB (0%)

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 60da071
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6464dc69b9108a0008ada8cb
😎 Deploy Preview https://deploy-preview-10888--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@alessbell
Copy link
Member Author

The size increase makes sense given the change to how the bundles were generated in 0.17.0 - we'll get these gains back as soon as the upstream fix lands.

@alessbell
Copy link
Member Author

Instead of reverting, we should be able to upgrade shortly to avoid undoing/redoing changes in tests. Related PR: benjamn/optimism#548

@alessbell
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

Please add a changeset via npx changeset before attempting a snapshot release.

@alessbell
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10888-20230517155323.

@alessbell
Copy link
Member Author

alessbell commented May 17, 2023

optimism sourcemaps error is gone: https://codesandbox.io/s/beautiful-lucy-z82hul?file=/src/index.jsx 🎉

Edit: hmm, it's back... Still investigating.

@alessbell
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10888-20230517165010.

@alessbell
Copy link
Member Author

/release:pr

@alessbell
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10888-20230517165635.

@alessbell alessbell changed the title Use optimism 0.16.2 Use optimism 0.17.2 May 17, 2023
@alessbell
Copy link
Member Author

alessbell commented May 17, 2023

Unfortunately, while these dependency bumps fix all sourcemap warnings, they don't solve the Codesandbox error. Still investigating.

Edit: looks like a transpilation bug, more details: codesandbox/sandpack#940

@alessbell alessbell changed the title Use optimism 0.17.2 Use optimism 0.17.4 May 17, 2023
@alessbell
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10888-20230517195610.

@alessbell alessbell merged commit 1562a2f into release-3.8 May 17, 2023
5 checks passed
@alessbell alessbell deleted the optimism-16.2 branch May 17, 2023 20:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants