Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stuck pending state when refetching a query that returns a result that is deeply equal to data in the cache #11086

Merged
merged 6 commits into from Jul 21, 2023

Conversation

jerelmiller
Copy link
Member

Fixes #11085

Fixes an issue where a call to refetch, fetchMore, or changing skip to false that returned a result deeply equal to data in the cache would get stuck in a pending state and never resolve. This meant the Suspense fallback would be displayed indefinitely.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

🦋 Changeset detected

Latest commit: 096b89f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.1 KB (+0.1% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.68 KB (+0.1% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 42.28 KB (+0.09% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.39 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.22 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.21 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.2 KB (0%)
import { useQuery } from "dist/react/index.js" 4.26 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.08 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.57 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.39 KB (0%)
import { useMutation } from "dist/react/index.js" 2.5 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.48 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.23 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.2 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 4.72 KB (+0.55% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.15 KB (+0.69% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" 4.2 KB (+0.68% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.63 KB (+0.9% 🔺)
import { useReadQuery } from "dist/react/index.js" 2.69 KB (+1.14% 🔺)
import { useReadQuery } from "dist/react/index.js" (production) 2.67 KB (+1.15% 🔺)
import { useFragment } from "dist/react/index.js" 2.04 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2 KB (0%)

@jerelmiller
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-11086-20230721035547.

@jerelmiller jerelmiller changed the title Fix refetch bug Fix stuck pending state when refetching a query that returns a result that is deeply equal to data in the cache Jul 21, 2023
Copy link
Member

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@jerelmiller jerelmiller merged commit 0264fee into release-3.8 Jul 21, 2023
15 checks passed
@jerelmiller jerelmiller deleted the fix-refetch-bug branch July 21, 2023 16:51
@github-actions github-actions bot mentioned this pull request Jul 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useSuspenseQuery's refetch keeps suspending when variables not changed
2 participants