New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call devtools registration after ApolloClient is fully set up #11193
Conversation
🦋 Changeset detectedLatest commit: f6da22f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
/release:pr |
A new release has been made for this PR. You can install it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for hopping on to fix this right away! 🎉
This delays devtools registration until after the
ApolloClient
constructor has finished setting up the Apollo Client instance fully.As the new registration can happen synchronously if the devtools extension is already loaded at the time the
ApolloClient
instance is created, previously this would add to aCannot read properties of undefined
error, as theObservableQuery
had not been constructed yet.Fixes #11192
Can be verified with these CodeSandboxes:
Checklist: