Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple canonicalStringify from ObjectCanon #11254

Merged
merged 18 commits into from
Oct 5, 2023
Merged

Decouple canonicalStringify from ObjectCanon #11254

merged 18 commits into from
Oct 5, 2023

Commits on Sep 26, 2023

  1. Move stub implementation of canonicalStringify to utilities/common.

    @benjamn
    benjamn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    ff4bb9f View commit details
    Browse the repository at this point in the history

  2. Trivial implementation of canonicalStringify that makes tests pass.

    @benjamn
    benjamn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    729b48e View commit details
    Browse the repository at this point in the history

  3. Avoid hack of calling getStoreKeyName.setStringify(canonicalStringify).

    @benjamn
    benjamn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    aeaf611 View commit details
    Browse the repository at this point in the history

  4. Improve canonicalStringify implementation using SortingTrie.

    @benjamn
    benjamn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    5d57cda View commit details
    Browse the repository at this point in the history

  5. Bump .size-limit.cjs limits slightly.

    @benjamn
    benjamn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    be458d3 View commit details
    Browse the repository at this point in the history

  6. Add a changeset file.

    @benjamn
    benjamn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    fa4ff5f View commit details
    Browse the repository at this point in the history

  7. Make API extractor happy about canonicalStringify move.

    @benjamn
    benjamn committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    50e485a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Keep getStoreKeyName.setStringify but use canonicalStringify by default. 

    #11254 (comment)
    @benjamn
    benjamn committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    9211fd4 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Give storeKeyNameStringify an explicit type signature. 

    Co-authored-by: Lenz Weber-Tronic <lorenz.weber-tronic@apollographql.com>
    @benjamn @phryneas
    benjamn and phryneas committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    badac8b View commit details
    Browse the repository at this point in the history

  2. Better comment for canonicalStringify function. 

    Co-authored-by: Lenz Weber-Tronic <lorenz.weber-tronic@apollographql.com>
    @benjamn @phryneas
    benjamn and phryneas committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    cbfdb9b View commit details
    Browse the repository at this point in the history

  3. Conserve total number of sorted arrays retained by canonicalStringify.

    @benjamn
    benjamn committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c8cab39 View commit details
    Browse the repository at this point in the history

  4. Use Map to avoid two-level trie nodes and Object.create(null).

    @benjamn
    benjamn committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2311b8d View commit details
    Browse the repository at this point in the history

  5. Add tests of canonicalStringify and helper lookupSortedKeys. 

    The lookupSortedKeys function is not intended to be used directly, but
seemed worth unit testing nevertheless.
    @benjamn
    benjamn committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1b4aad3 View commit details
    Browse the repository at this point in the history

  6. Run prettier.

    @benjamn
    benjamn committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    dad8607 View commit details
    Browse the repository at this point in the history

  7. Switch to a simpler lookup strategy not involving a trie.

    @benjamn
    benjamn committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c5446ac View commit details
    Browse the repository at this point in the history

  8. Reduce size limits after simplifying canonicalStringify.

    @benjamn
    benjamn committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5636a34 View commit details
    Browse the repository at this point in the history

  9. Another comment, and one less call to Object.getPrototypeOf.

    @benjamn
    benjamn committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c2a8e34 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Replace isArraySorted with keys.every(everyKeyInOrder). 

    #11254 (comment)
    @benjamn
    benjamn committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    d0aa030 View commit details
    Browse the repository at this point in the history