Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes argument handling for invariant log messages. #11266

Merged
merged 5 commits into from Oct 5, 2023

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Oct 2, 2023

This is the follow-up to #11261 - it seems like #11195 made some situations better, some others worse. This time I'm adding a bunch of tests to make sure everything is covered thoroughly.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

🦋 Changeset detected

Latest commit: 6dcbdbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.05 KB (+0.07% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.38 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 41.94 KB (+0.07% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.47 KB (+0.08% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.22 KB (+0.08% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.22 KB (+0.57% 🔺)
import { ApolloProvider } from "dist/react/index.js" (production) 1.2 KB (+0.49% 🔺)
import { useQuery } from "dist/react/index.js" 4.28 KB (+0.28% 🔺)
import { useQuery } from "dist/react/index.js" (production) 4.1 KB (+0.39% 🔺)
import { useLazyQuery } from "dist/react/index.js" 4.59 KB (+0.22% 🔺)
import { useLazyQuery } from "dist/react/index.js" (production) 4.41 KB (+0.29% 🔺)
import { useMutation } from "dist/react/index.js" 2.54 KB (+0.55% 🔺)
import { useMutation } from "dist/react/index.js" (production) 2.52 KB (+0.51% 🔺)
import { useSubscription } from "dist/react/index.js" 2.24 KB (+0.18% 🔺)
import { useSubscription } from "dist/react/index.js" (production) 2.2 KB (+0.05% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" 4.6 KB (+0.22% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.03 KB (+0.32% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" 4.12 KB (+0.34% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.54 KB (+0.45% 🔺)
import { useReadQuery } from "dist/react/index.js" 2.98 KB (+0.4% 🔺)
import { useReadQuery } from "dist/react/index.js" (production) 2.93 KB (+0.61% 🔺)
import { useFragment } from "dist/react/index.js" 2.09 KB (+0.76% 🔺)
import { useFragment } from "dist/react/index.js" (production) 2.04 KB (+0.92% 🔺)

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit a323213
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/651ac9ba3dd9c70007be6e67
😎 Deploy Preview https://deploy-preview-11266--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 4ad3038
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/651aca00ef47a80008f338cd
😎 Deploy Preview https://deploy-preview-11266--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phryneas phryneas changed the title add tests, fix invariant logging Fixes argument handling for invariant log messages. Oct 2, 2023
Copy link
Member

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to have tests here now! LGTM

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 6dcbdbd
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/651f04775f69fd000817f490
😎 Deploy Preview https://deploy-preview-11266--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller jerelmiller merged commit 5192cf6 into main Oct 5, 2023
21 checks passed
@jerelmiller jerelmiller deleted the pr/fix-invariant-logging branch October 5, 2023 18:55
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants