Require sha when creating snapshot releases on forks

[jerelmiller]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 64809a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	38.45 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	46.28 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	43.84 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	33.96 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	31.87 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.22 KB (0%)
import { useQuery } from "dist/react/index.js"	5.27 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.35 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.51 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.58 KB (0%)
import { useMutation } from "dist/react/index.js"	3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.73 KB (0%)
import { useSubscription } from "dist/react/index.js"	3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.1 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.92 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.57 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.69 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.17 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.12 KB (0%)
import { useFragment } from "dist/react/index.js"	2.27 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.22 KB (0%)

[phryneas]

What's the difference between these two exit 1?

[jerelmiller]

Oops, I forgot to copy a critical line from my testing. The Get sha step should have continue-on-error: true set, which would mean that instead of failing the entire job, it would allow it to continue. The idea was that if it failed, it would add the comment to the PR "Did you forget...", then fail early, hence this step.

The other option would be to update every step with if: steps.parse-sha-outcome != 'failure', but that felt like a lot and figured I'd just exit early instead. That plus the job itself would fail rather than succeed in that case so we'd get alerts that way too.

[jerelmiller]

Added here: https://github.com/apollographql/apollo-client/pull/11794/files#diff-9dc5e53b8fc4bd9d74ca8c2d8d9d5bf7f94c6a8ccc49f2bcc142ec5c171686d1R38

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	64809a3
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/6626905ae0b50200089bb957
😎 Deploy Preview	https://deploy-preview-11794--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[phryneas]

Then it looks good to me and I think we can't actually test this without merging, so LGTM? :)

[jerelmiller]

@phryneas I tested this over in https://github.com/alessbell/good-snow-tire-demo/blob/main/.github/workflows/comment.yml with alessbell/good-snow-tire-demo#83 and alessbell/good-snow-tire-demo#82, so from what I can tell, we should be good 🙂

[alessbell]

Yep, this was tested - we paired on it last week :) LGTM 🚀