Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the rehackt dependency to ^0.1.0 #11803

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Apr 23, 2024

As we discussed yesterday.

Quoting the 0.1.0 release notes:


In the latest React 19 Canary, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED was renamed to __CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE and __SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE.

Since __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED is not present in the exports anymore, some bundlers will error on every reference of that.
Even if it was used in a way that would actually not be breaking, like

if (React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED) {
  // more defensive code here
}

your consumer builds might break as a result.

This release exports all three internal objects as undefined (or their real value), which means that such a defensive approach would not be breaking builds.

Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: 7021168

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 23, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.61 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.48 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 44.04 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.15 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.04 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.26 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.35 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.1 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.92 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.57 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.69 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.31 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.25 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (0%)

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 7021168
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66293a355383d50008bf61e9
😎 Deploy Preview https://deploy-preview-11803--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the auto-cleanup 🤖 label Apr 23, 2024
Base automatically changed from release-3.10 to main April 24, 2024 15:49
@phryneas phryneas merged commit bf9dd17 into main Apr 24, 2024
33 checks passed
@phryneas phryneas deleted the pr/update-rehackt-0.1.0 branch April 24, 2024 17:53
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants