Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetchMoreForQueryId safeguards #3469

Merged
merged 5 commits into from
May 25, 2018
Merged

Conversation

doomsower
Copy link
Contributor

This PR addresses #3466

There are safety checks for unmounted queries, but there are not checks for fetchMore. This PR adds them.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@hwillson hwillson self-assigned this May 25, 2018
@hwillson
Copy link
Member

Hi @doomsower - thanks for submitting this PR. There is a bit of overlap between your changes and the recently merged changes from #3367. I'll get things cleaned up a bit, and will have this merged in shortly. Thanks!

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @doomsower! Since I had already merged #3367, most of your changes have been superseded by that PR. I've adjusted the CHANGELOG a bit in this PR, added some extra tests, and removed the additional safeguard that was added in the markQueryError function. That safeguard wasn't really needed, since a similar check is already being done in markQueryResultClient, which markQueryError calls. We should be all set to get this merged - thanks again!

@hwillson hwillson merged commit 4467d95 into apollographql:master May 25, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants