fix(fragment): fragment on query fix #3484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
hwillson
requested changes
May 23, 2018
There was a problem hiding this comment.
This looks great @abhiaiyer91 - thanks for looking into this! Any chance you could add some tests for this? Your tests in apollographql/react-apollo#1987 were great; maybe they could be re-hashed for AC specifically? If you don't have time to finalize this right now, let me know and I'll dive in. Thanks again!
|
I shall! |
hwillson
approved these changes
May 24, 2018
hwillson
requested changes
May 24, 2018
There was a problem hiding this comment.
Hi @abhiaiyer91 - just a couple more things, then we should be all set here:
- It looks like some of the
apollo-cache-inmemorytests are failing due to these changes impacting the way inline fragments work. TheidValue.id === 'ROOT_QUERY'check is returning true for all inline fragments in the failing tests, even though those tests intentionally have some inline fragments querying against invalid types. - The test you've added doesn't seem to fail without the
idValue.id === 'ROOT_QUERY'change. It would be awesome if we could make sure it fails before these changes are applied, so we know we have our regression bases covered.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this issue #3402