Fix IntrospectionFragmentMatcher handling of fragment on root query #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rynobax I have run into the same issue. Any temporary work arounds for the moment? |
|
@ellioseven Unfortunately, my workaround has been to not use fragments on the root query 😄 |
|
Dang. Me too :( A little polite nudge to @abhiaiyer91 to see if he can take a quick look at this, following from #3402. Would be a life saver to get this merged. |
benjamn
force-pushed
the
queryFragmentFix
branch
from
9b6ef2d
to
2f63064
Compare
|
We have some solid use cases for this at my company, and this is blocking us upgrading. Is there any chance of someone cutting a new release? I can't work out how to fetch from a git subdirectory through package.json :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a bug where IntrospectionFragmentMatcher will break when using a fragment on the root query (example here). #3402 suggested applying #3484's fix for the heuristic matcher to the fragment matcher. It seems to have worked.