Correct Dangerfile to account for commits which aren't tied to a GitHub user. #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these were already defined higher up, so it's worth using their shorter notations!
…defined. As demonstrated in the Danger test[0] on #3444, the `author` property is not always set. While it could make sense to individually look at each individual commit's "login", Git commits are not always tied to GitHub users so it seems more relevant to look at the GitHub login of the user (or bot!) opening the PR, when making decisions about whether to apply bot-only policies. [0]: https://circleci.com/gh/apollographql/apollo-client/8427
hwillson
approved these changes
May 23, 2018
| @@ -57,8 +58,17 @@ const raiseIssueAboutPaths = ( | |||
| } | |||
| }; | |||
|
|
|||
| const authors = commits.map(x => x.author.login); | |||
| const isBot = authors.some(x => ['greenkeeper', 'renovate'].indexOf(x) > -1); | |||
| console.log("GitHub PR Username:", pr && pr.user && pr.user.login); | |||
There was a problem hiding this comment.
When you console.log from a danger file, does it show up anywhere?
There was a problem hiding this comment.
Yup! In the CircleCI output for the Danger script host. On this PR, that's in ci/circleci: Danger.
There was a problem hiding this comment.
Ah, makes sense - thanks @abernix!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my commit message on 5d3889c:
As demonstrated in the Danger test0 on #3444, the
authorproperty is not always set. While it could make sense to individually look at each individual commit's "login", Git commits are not always tied to GitHub users so it seems more relevant to look at the GitHub login of the user (or bot!) opening the PR, when making decisions about whether to apply bot-only policies.