Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional generics to cache manipulation methods #3541

Merged
merged 3 commits into from
Jun 5, 2018
Merged

Add optional generics to cache manipulation methods #3541

merged 3 commits into from
Jun 5, 2018

Conversation

mvestergaard
Copy link
Contributor

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

This sort of falls outside of all of the checklist items above, so I checked them.

Currently, when using the read/write methods on the cache, it is very easy to make mistakes, by simply misspelling a variable for example.
This PR adds optional generic arguments to methods used to manipulate the cache.
I've made sure to add a default for all of the new generic arguments, so it should not break anything.

@apollo-cla
Copy link

@mvestergaard: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@apollo-cla
Copy link

apollo-cla commented Jun 4, 2018

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

@hwillson hwillson self-assigned this Jun 5, 2018
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @mvestergaard! We should be good to go here - LGTM!

@hwillson hwillson merged commit dfa6cd5 into apollographql:master Jun 5, 2018
@mvestergaard mvestergaard deleted the cache-generics branch June 5, 2018 15:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants