Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn when user try to use apollo-boost as an apollo-client #3551

Merged
merged 9 commits into from
Jul 20, 2018

Conversation

quentin-
Copy link
Contributor

@quentin- quentin- commented Jun 6, 2018

馃憢,

It is a common mistake to use the apollo boost constructor as an Apollo client constructor

This PR prints a warning when initializing apollo boost with unsupported options.

Checklist:

  • If this PR is a new feature,
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API

@quentin- quentin- force-pushed the warn-boost branch 3 times, most recently from 2ac275e to f7c380a Compare June 6, 2018 21:38
@hwillson hwillson self-assigned this Jul 10, 2018
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @quentin-! I'm not super crazy about the idea of having to maintain PRESET_CONFIG_KEYS, when we already have the same details in the PresetConfig interface, but there isn't much we can do about this right now (and I totally get why you set it up like this - this isn't a knock against anything you've done! 馃檪). I messed around with Typescript transforms a bit and ran into a world of hurt trying to get the transforms working with rollup properly. Given that Apollo Boost is going to disappear when Apollo Client 3 is released though, I think we should be okay here for now. Thanks again - LGTM!

@hwillson hwillson merged commit cfcd65c into apollographql:master Jul 20, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants