Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pre-configured cache to be given as config option to Apollo Boost Client #3561

Merged
merged 3 commits into from
Jun 13, 2018

Conversation

dandean
Copy link

@dandean dandean commented Jun 8, 2018

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)

This is related to #3220

  • Make sure all of the significant new logic is covered by tests

New tests have been added


I've read through some discussions on this and I see that there are different opinions on the appropriateness of this kind of change and how it relates to your idea of the opinionated nature of ApolloBoost. Obviously, feel free to close the PR and disregard.

The challenge I'm running into, and which motivated this pull request, is that I have one small configuration change I need to make to the internal InMemoryCache configuration. That one small change is forcing me to drop ApolloBoost and instead configure everything manually.

It would be more user-friendly to be able to use ApolloBoost as is, but pass in specific dependency's when required while still retaining the rest of the defaults of ApolloBoost.

Anyhow, thanks for taking the time to read through this. I'll continue with my manual configuration for now. If this is a PR you're interested in moving forward with, let me know if there are any other changes you'd like to see implemented here. Otherwise, thanks for writing these great tools. 👋

@ghost ghost added the feature label Jun 8, 2018
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @dandean - let's do this! 👍

@dandean
Copy link
Author

dandean commented Jun 15, 2018

🎉 Thank you, @hwillson.

@damassi
Copy link

damassi commented Jun 17, 2018

🎉

TheMightyPenguin added a commit to TheMightyPenguin/apollo-client that referenced this pull request Jul 23, 2018
Support for this option was added in [apollographql#3561](apollographql#3561) but it was not documented yet.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants