Bump graphql version to 14.0.0 #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So graphql are transitioning to real semver finally. This should fix apollographql#3562 I've set the devDependency to graphql@14.0.0-rc.2 to be able to be able to run the tests on the new version and make sure everything's fine. But I'm not sure if you think its ok to merge with that release candidate. Also I think the semver in peerDependencies is more verbose than it should be: ```js "peerDependencies": { "graphql": "^0.11.0 || ^14.0.0" } ``` This should cover all of the graphql versions from 0.11 and up, since ["^" includes minor and patch versions](https://bytearcher.com/articles/semver-explained-why-theres-a-caret-in-my-package-json/)
|
@ivank: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
hwillson
approved these changes
Jul 10, 2018
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So graphql are transitioning to real semver finally. This should fix #3562
I've set the devDependency to graphql@14.0.0-rc.2 to be able to be able to run the tests on the new version and make sure everything's fine. But I'm not sure if you think its ok to merge with that release candidate.
Also I think the semver in peerDependencies is more verbose than it should be:
This should cover all of the graphql versions from 0.11 and up, since "^" includes minor and patch versions
Checklist: