Remove "[GraphQL|Network] error" from error messages

[lorensr]

Implements FR: apollographql/apollo-feature-requests#46

For consistency, strips the prefix from both GraphQL and Network errors. See "Stripping prefix" in #1812 (comment)

[hwillson]

Hi @lorensr - it looks like you might have prettier (or similar) rules in place that conflict with the defaults used by Apollo Client. Can you update this PR to revert all styling back to the defaults used by AC? For example, semi-colons are being stripped when we'd like them to be preserved. Thanks!

[codecov]

Codecov Report

Merging #3892 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3892   +/-   ##
=======================================
  Coverage   89.14%   89.14%           
=======================================
  Files          43       43           
  Lines        2358     2358           
  Branches      575      552   -23     
=======================================
  Hits         2102     2102           
  Misses        240      240           
  Partials       16       16

Impacted Files	Coverage Δ
packages/apollo-client/src/errors/ApolloError.ts	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5eaf2d...de577c8. Read the comment docs.

[lorensr]

Oops, thanks—the commit hook got me! It's working for me after adding --no-config, if that's okay?

[benjamn]

@lorensr @hwillson Honestly I think we should remove the auto-git add prettier behavior here. It totally undermines the expectation that git should only commit code that you git added.

[hwillson]

@benjamn Totally agree - this has thrown me off multiple times. Noted and I'll take care of it shortly (unless you beat me to it). Thanks!

[hwillson]

Just re-visiting this a bit @benjamn; if we drop the git add, then we're no longer enforcing staged file prettier cleanup. We're currently doing this on all of our main repos, so this might be a larger discussion. For now though I think @lorensr's suggestion of making sure the pre-commit prettier hook doesn't use a local config if one exists (since we don't want it to), makes sense.

Requested changes were made.

[abernix]

Just as a flag, Node.js usually flags changes to error message properties as breaking changes which must be included in semver-major releases. I don't know if we need to subscribe to that, but it's worth mentioning.

[hwillson]

That's a really great point @abernix. People could be relying on the error message prefix to drive application logic. I think it makes sense to follow Node's lead here, so I'll add this to the Release 3.0 milestone. Thanks!

[ScreamZ]

Will this will be merged soon?

[mattdavenport]

Any updates here? This would be really valuable in displaying errors much more efficiently. Thanks!

[ScreamZ]

@benjamn @hwillson

[austinChappell]

Any updates on this?

[hwillson]

Thanks very much for kickstarting this @lorensr!