Add client awareness support #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To assist with Engine's client awareness features, these changes allow `name` and `version` params to be passed into the `ApolloClient` constructor. These properties are then passed along via the defined `Link` chain, within the operation `context` made available to each `Link`. Any `Link` interested in using these values can pull them from the `context.clientAwareness` object.
…lographql/apollo-client into hwillson/add-client-headers
zionts
reviewed
Nov 19, 2018
evans
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Super awesome @hwillson! Thank you for putting this together. I left a couple of suggestions on the documentation in case that makes things a bit more clear. I wasn't quite sure what it meant to represent connections and felt we could be a bit more specific about the mechanics of name and version
❤️ the testing
Co-Authored-By: hwillson <hugh@octonary.com>
Co-Authored-By: hwillson <hugh@octonary.com>
Co-Authored-By: hwillson <hugh@octonary.com>
Co-Authored-By: hwillson <hugh@octonary.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
ApolloClientconstructor to acceptnameandversionparams, that can be used to support Apollo Server Client Awareness functionality. These client awareness properties are passed into the defined Apollo Link chain, and are then ultimately sent out as custom headers with outgoing requests.Associated Apollo Link PR: apollographql/apollo-link#872