Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export wrap as es2015 instead of commonjs #4158

Merged
merged 8 commits into from
Jan 2, 2019
Merged

Export wrap as es2015 instead of commonjs #4158

merged 8 commits into from
Jan 2, 2019

Conversation

ardatan
Copy link
Contributor

@ardatan ardatan commented Nov 20, 2018

Fixes #4071

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@ardatan ardatan force-pushed the fix/optimism branch 2 times, most recently from c299774 to c4f4139 Compare November 20, 2018 01:22
@ardatan
Copy link
Contributor Author

ardatan commented Dec 13, 2018 •
edited
Loading

Any comments or reviews? @hwillson @benjamn

@hwillson hwillson assigned hwillson and benjamn and unassigned hwillson Jan 2, 2019
benjamn
benjamn approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ardatan!

@benjamn benjamn merged commit be30577 into apollographql:master Jan 2, 2019
@ardatan ardatan deleted the fix/optimism branch January 2, 2019 19:58
@benjamn benjamn mentioned this pull request Jan 18, 2019
Closed
benjamn added a commit that referenced this pull request Jan 18, 2019
@benjamn
Update optimism to use its new TypeScript declarations.
29d09ab 
Wow, I should have done this sooner. Super simple:
benjamn/optimism@03b3f88

Follow-up to #4158.
Should fix #4327.
@benjamn benjamn mentioned this pull request Jan 18, 2019
Merged
benjamn added a commit that referenced this pull request Jan 18, 2019
@benjamn
Update optimism to use its new TypeScript declarations. (#4331)
72c5587 
Since we've been struggling to declare correct types for the `optimism`
npm package (for example: #4158, #4327), I finally decided to move the
declarations into the `optimism` package itself: benjamn/optimism@03b3f88

Pretty easy! I wish I'd done this sooner.

Should fix #4327.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

@hwillson hwillson Awaiting requested review from hwillson

Assignees

@benjamn benjamn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rollup has trouble importing apollo-cache-inmemory CommonJS dependencies.
3 participants
@ardatan @benjamn @hwillson