Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link in HeuristicFragmentMatcher error #4220

Merged
merged 3 commits into from
Jan 2, 2019
Merged

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented Dec 5, 2018

We changed the docs but not the link

We changed the docs but not the link
@smolinari
Copy link
Contributor

@stubailo - you say "we". Are you back on the team? Or just contributing from the "outside". 😃

Scott

@stubailo
Copy link
Contributor Author

stubailo commented Dec 6, 2018

Hi Scott! I say "we" as someone who worked on this code at the time.

@smolinari
Copy link
Contributor

smolinari commented Dec 6, 2018

Ah! I didn't see the whole context. I was thinking (hoping) you were back on the team in some official manner. Too bad it isn't so. 😞

Scott

@hwillson
Copy link
Member

hwillson commented Dec 6, 2018

After @stubailo left, we commissioned a 14 foot statue of him, and put it in the Apollo HQ lobby. Now he can never truly leave ... 🙂.

@settings settings bot removed the in progress label Dec 12, 2018
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @stubailo - thanks very much!

@hwillson hwillson merged commit b1ca202 into master Jan 2, 2019
@hwillson hwillson deleted the stubailo-patch-1 branch January 2, 2019 20:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants