Only return newData when querying current results for no-cache or network-only queries #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This approach looks good @danilobuerger - thanks! |
danilobuerger
changed the title
|
@hwillson amended and rebased |
…work-only queries
hwillson
approved these changes
Feb 16, 2019
|
@hwillson this functionality will be only in v2.5.0 ? Any info about date of release. And huge thank you to @danilobuerger!!! |
This was referenced Apr 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
QueryManager.getCurrentQueryResult(and thusObservable.currentResult) should only returnnewDatafor the queries current result, as the query is not supposed to return cached data. This will then fix a long standing bug in react-apollo where cached data shows up onnetwork-onlyqueries.