Fix getCurrentResult() not always returning loading with fetchPolicy no-cache #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracmak
commented
Apr 10, 2019
benjamn
approved these changes
Apr 11, 2019
|
any idea when this will be released? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug created by #4352. Basically what changed was an optimization that bypassed querying the cache for no-cache fetchPolicy's and instead returning
{ data: undefined, partial: false }directly. The problem was that the original code didn't return that. It returned{ data: undefined, partial: true }because of how the cache query failed. So in the getCurrentResult() function, the loading check stopped working briefly because queryLoading was only honored iffetchPolicy === 'network-only'and the other path wasn't getting hit anymore. This fixes the bug by expanding the fetchPolicy check to include 'no-cache'