Compile ESM bundle to CJS using Babel instead of Rollup. #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
compile-esm-to-cjs-with-babel-instead-of-rollup
branch
from
9e8538d
to
98ac2da
Compare
This was referenced Jun 6, 2019
hwillson
added a commit
to apollographql/react-apollo
that referenced
this pull request
Jun 11, 2019
Follows in the footsteps of apollographql/apollo-client#4911.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: #4843 (comment)
Closes my previous PR #4864, which attempted a similar ESM-to-CJS transformation using TypeScript instead of Babel.
I was tempted to use
@babel/plugin-transform-runtimehere, but that would have required adding a runtime dependency on@babel/runtimeto all Apollo Client packages. Also, since we're only running the modules transform, the set of runtime helpers is effectively limited tointeropRequireDefaultandinteropRequireWildcard, whose implementations can be inlined safely without increasing bundle sizes very much.Fixes #4843.