refactor custom isEqual to utilise lodash.isequal #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
benjamn
approved these changes
Jun 4, 2019
|
@benjamn thanks- this is certainly a simpler fix to land, but a proper fix would be to deprecate and remove it all together. |
|
I am not sure why netlify deploy failed, but I doubt it has to do with any of the changes I've done. |
benjamn
added a commit
that referenced
this pull request
Jun 5, 2019
Follow-up to #4915. I have kept the tests from that PR, just not the lodash-based implementation of isEqual. The lodash.isequal package has a ton of extra features we don't need, and weighs in at a whopping 10KB minified (3.8KB after gzip). Very little of that machinery is really necessary to fix #4824. I extracted this functionality into a separate npm package called @wry/equality, so that we have the flexibility to depend on the same logic in other packages without importing apollo-utilities.
benjamn
added a commit
that referenced
this pull request
Jun 6, 2019
Follow-up to #4915. I have kept the tests from that PR, just not the lodash-based implementation of isEqual. The lodash.isequal package has a ton of extra features we don't need, and weighs in at a whopping 10KB minified (3.8KB after gzip). Very little of that machinery is really necessary to fix #4824. I extracted this functionality into a separate npm package called @wry/equality, so that we have the flexibility to depend on the same logic in other packages without importing apollo-utilities.
benjamn
added a commit
that referenced
this pull request
Jun 6, 2019
* Reimplement isEqual without pulling in massive lodash.isequal. Follow-up to #4915. I have kept the tests from that PR, just not the lodash-based implementation of isEqual. The lodash.isequal package has a ton of extra features we don't need, and weighs in at a whopping 10KB minified (3.8KB after gzip). Very little of that machinery is really necessary to fix #4824. I extracted this functionality into a separate npm package called @wry/equality, so that we have the flexibility to depend on the same logic in other packages without importing apollo-utilities. * Treat @wry/equality as an external package when bundling apollo-utilities. * Update @wry/equality to latest version (0.1.2). * Mention PR #4924 in CHANGELOG.md.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested here: #4903 (review)
I don't care which one of the PRs get's merged, as long as the bug is fixed
Checklist: