Stop calling addTypenameToDocument before InMemoryCache reads/writes. #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding __typename fields to the query by calling addTypenameToDocument used to be necessary for writing results to the cache, but now __typename fields in result objects are automatically written to the cache, so no transformation is necessary. ApolloClient still calls cache.transformDocument to get a query with __typename fields to send to the server, and the cache still relies on results from the server coming back with __typename fields, but the cache no longer needs the query to be transformed to include __typename. Compared to PR #5311, this commit should not be a breaking change.
This was referenced Sep 13, 2019
Merged
hwillson
approved these changes
Sep 13, 2019
| dataIdFromObject: this.config.dataIdFromObject, | ||
| }); | ||
|
|
||
| this.broadcastWatches(); | ||
| } | ||
|
|
||
| public diff<T>(query: Cache.DiffOptions): Cache.DiffResult<T> { | ||
| public diff<T>(options: Cache.DiffOptions): Cache.DiffResult<T> { |
There was a problem hiding this comment.
Thanks for changing these to options👌.
StephenBarlow
pushed a commit
that referenced
this pull request
Oct 1, 2019
…#5320) Adding __typename fields to the query by calling addTypenameToDocument used to be necessary for writing results to the cache, but now __typename fields in result objects are automatically written to the cache, so no transformation is necessary. ApolloClient still calls cache.transformDocument to get a query with __typename fields to send to the server, and the cache still relies on results from the server coming back with __typename fields, but the cache no longer needs the query to be transformed to include __typename. Compared to PR #5311, this commit should not be a breaking change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
__typenamefields to the query by callingaddTypenameToDocumentused to be necessary for writing results to the cache, but now (thanks to this PR)__typenamefields in result objects are automatically written to the cache, so no transformation is necessary.ApolloClient still calls
cache.transformDocumentto get a query with__typenamefields to send to the server, and the cache still relies on results from the server coming back with__typenamefields, but the cache no longer needs the query to be transformed to include__typename.Compared to PR #5311, this commit should not be a breaking change. PR #5311 ultimately failed because hiding
__typenamefields threatened to disruptreadFragment=> transform =>writeFragmentworkflows, becausewriteFragmentneeds__typenameinformation to work properly, soreadFragmentmust return that information.