Make InMemoryCache#evict remove data from all EntityStore layers. #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Folks testing AC3 have already reported some confusion about evicted data seeming to reappear in the context of optimistic mutation updates: #5746 (comment) To prevent this confusion, I think we need to honor the force implied by the word "evict" and remove all traces of the given dataId/fieldName from all layers the cache, rather than only evicting from the top layer of the cache (that is, this.optimisticData).
Sounds good! I wasn't aware of different layers to the cache - I'd be interested to understand that better. Related but separate: It doesn't look like evict is in the DataProxy Type Definition. Is this intentional, or to come? |
|
@ahrnee If you're interested, see #4319 for an explanation of the optimistic cache layering. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folks testing AC3 (👋 @ahrnee) have already reported some confusion about evicted data seeming to reappear in the context of optimistic mutation updates: #5746 (comment)
To prevent this confusion, I think we need to honor the force implied by the word
evictand remove all traces of the givendataId/fieldNamefrom all layers the cache, rather than only evicting from the top layer of the cache (namely,this.optimisticData).