Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Upgrade apollo to version 3.x #209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade apollo to version 3.x #209

wants to merge 2 commits into from

Conversation

sync
Copy link

@sync sync commented Aug 27, 2019

Why ?

A couple of people from the reasonml community end up with multiple versions of react-apollo in their dependencies and spend time debugging why reason-apollo is no not working for them. (aka: have both react-apollo 2 and react-apollo 3)

So let's use latest Apollo.

TODO

  • understand why the swapi example no longer runs

Pull Request Labels

  • feature
  • blocking
  • docs

@sync
Copy link
Author

sync commented Aug 27, 2019

if using yarn temporarily you can force one revision of react-apollo by adding this into your package.json:

"resolutions": {"react-apollo": "3.0.1"}

@MargaretKrutikova
Copy link
Contributor

What error did you get when trying to run swapi? Was it the error about invalid hooks call and three options on what might be causing it?
I got this error trying to run it, and the reason is this:

You might have more than one copy of React in the same app.

I don't think yarn (or npm) handle dependencies properly when developing locally, since the example project is referring to reason-apollo as ../../ in package.json. I found that npm dedupe reason-react after installing node_modules fixes the error.

This problem doesn't appear if you install reason-apollo as usual via yarn add reason-apollo because the dependencies are handled differently in that case.
Let me know if it helps to fix the issue you are having!

@sync
Copy link
Author

sync commented Sep 20, 2019

Completely forgot to reply sorry. So do you think it’s safe the merge. Is it working for you ?

@MargaretKrutikova
Copy link
Contributor

It worked for me when I tested, but it would be nice to get an approval for this from the maintainers 😄

@peterpme
Copy link

Bump - can we merge this in @Gregoirevda ?

@peterpme
Copy link

Bump - can we please merge this in @Gregoirevda

If you're no longer able to maintain this do you mind having the community help? We're relying on this 😄

@GTDev87
Copy link

GTDev87 commented Jun 12, 2020

There are a few performance issues improvements with AC3 that I'm interested in integrating into my project (apollographql/apollo-client#5773). I'd very much like this to be supported.

So bump.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants