fix: ssr logic shouldn't be used when rendering from the client #5839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebm
commented
Jan 24, 2020
| @@ -51,10 +52,11 @@ describe('useQuery Hook', () => { | |||
|
|
|||
| describe('General use', () => { | |||
| it('should handle a simple query properly', async () => { | |||
| let resultData; | |||
There was a problem hiding this comment.
I modified this test to ensure it never gets stuck in a loading state since it never did an expect if loading = true.
|
Can confirm this is indeed an issue when using v3.1.2. |
|
@hwillson, the gentlest bump on this. Issue is also stopping us to use |
|
Any update on this? I'd be willing to help out if needed :) |
2 tasks
|
Hi @mikebm 👋 Sorry for the delay here! There have been considerable changes to the library since this PR was opened— |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the SSR loading state could be returned on the client. The issue was introduced on this PR: https://github.com/apollographql/react-apollo/pull/3515/files
When temporarily using
disableNetworkFetcheson the client, it caused components to get stuck in a loading state coming from the SSR logic. This can be seen on network-only, and cache-and-network fetch policies when using a workaround as described here:#4814