Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

SSR false queries called on the server #1475

Closed
1 of 2 tasks
CameronGorrie opened this issue May 28, 2020 · 0 comments · Fixed by #1519
Closed
1 of 2 tasks

SSR false queries called on the server #1475

CameronGorrie opened this issue May 28, 2020 · 0 comments · Fixed by #1519
Labels

Comments

@CameronGorrie
Copy link
Contributor

CameronGorrie commented May 28, 2020

Overview

The query component re-exported w/types from react-graphql server side renders queries that should be opted out via the ssr: false option. This was observed when upgrading to react-apollo v3.1.4 and react-graphql v6.1.4 and can be reproduced in Shopify/web wherever we have legacy components using the HOC query implementation (ping me for additional reproduction steps).

The custom query hook implementation from react-graphql opts out of server side rendering as expected so we could fix forward by exporting an HOC from react-graphql that uses our query hook.

Related:
apollographql/react-apollo#3515 (comment)
apollographql/apollo-client#5839
apollographql/apollo-client#4814

Consuming repo

What repo were you working in when this issue occurred?

Shopify/Web


Checklist

  • Please delete the labels section before submitting your issue
  • I have described this issue in a way that is actionable (if possible)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant