You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
The query component re-exported w/types from react-graphql server side renders queries that should be opted out via the ssr: false option. This was observed when upgrading to react-apollo v3.1.4 and react-graphql v6.1.4 and can be reproduced in Shopify/web wherever we have legacy components using the HOC query implementation (ping me for additional reproduction steps).
The custom query hook implementation from react-graphql opts out of server side rendering as expected so we could fix forward by exporting an HOC from react-graphql that uses our query hook.
Overview
The query component re-exported w/types from
react-graphql
server side renders queries that should be opted out via thessr: false
option. This was observed when upgrading toreact-apollo v3.1.4
andreact-graphql v6.1.4
and can be reproduced in Shopify/web wherever we have legacy components using the HOC query implementation (ping me for additional reproduction steps).The custom query hook implementation from
react-graphql
opts out of server side rendering as expected so we could fix forward by exporting an HOC fromreact-graphql
that uses our query hook.Related:
apollographql/react-apollo#3515 (comment)
apollographql/apollo-client#5839
apollographql/apollo-client#4814
Consuming repo
Shopify/Web
Checklist
The text was updated successfully, but these errors were encountered: