Check Symbol.for exists in addition to Symbol before using it. #6324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, Symbol may be shimmed but not Symbol.for. In those cases, the existing code would throw on platforms with no native Symbol (IE11). This change ensures `Symbol.for` exists before using it, preventing the issue.
benjamn
approved these changes
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, Symbol may be shimmed but not Symbol.for. In those cases,
the existing code would throw on platforms with no native Symbol (IE11).
This change ensures
Symbol.forexists before using it, preventing theissue.
We encountered this issue because of a deferred script partially shimming Symbol. After trying to load Apollo code asynchronously, IE11 would occasionally throw.
Checklist: