Replace requireReactLazily with CJS bundle manipulation #6361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #5577 introduced a new way of lazily loading React to help prevent modern bundlers from requiring React when used with `@apollo/client/core` (in other words, without any of Apollo Client's React components). While this approach works well for applications that aren't using React, it introduces problems for bundlers and applications that are using React (as outlined in #6035 and #6352). There are several different ways we can address this, and we might do something more substantial in the future, but for now this commit manipulates Apollo Client's core CJS bundle at build time, to make the React require optional. Fixes #6035. Fixes #6352.
hwillson
commented
May 29, 2020
| @@ -30,8 +30,8 @@ | |||
| "dependencies": { | |||
| "@apollo/client": "file:../../../../dist", | |||
| "graphql": "^14.5.8", | |||
| "react": "^16.13.0", | |||
| "react-dom": "^16.13.0" | |||
| "react": "file:../../../../node_modules/react", | |||
There was a problem hiding this comment.
Note that the bundling example package lock updates, and these dependency changes, aren't directly related to the CJS bundling work in this PR. I did notice they needed to be adjusted while using the bundling app to test this PR's changes, so I thought I would leave them in here.
benjamn
approved these changes
May 29, 2020
|
Thanks for reviewing/tweaking @benjamn! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5577 introduced a new way of lazily loading React to help prevent modern bundlers from requiring React when used with
@apollo/client/core(in other words, without any of Apollo Client's React components). While this approach works well for applications that aren't using React, it introduces problems for bundlers and applications that are using React (as outlined in #6035 and #6352). There are several different ways we can address this, and we might do something more substantial in the future, but for now this commit manipulates Apollo Client's core CJS bundle at build time, to make the React require optional.Fixes #6035.
Fixes #6352.