Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace requireReactLazily with CJS bundle manipulation #6361

Merged
merged 2 commits into from
May 29, 2020
Merged

Replace requireReactLazily with CJS bundle manipulation #6361

merged 2 commits into from
May 29, 2020

Commits on May 29, 2020

  1. Replace requireReactLazily with CJS bundle manipulation 

    PR #5577 introduced a new way of lazily loading React
to help prevent modern bundlers from requiring React when used
with `@apollo/client/core` (in other words, without any of
Apollo Client's React components). While this approach works
well for applications that aren't using React, it introduces
problems for bundlers and applications that are using React
(as outlined in #6035 and #6352). There are several different ways
we can address this, and we might do something more substantial
in the future, but for now this commit manipulates Apollo Client's
core CJS bundle at build time, to make the React require optional.

Fixes #6035.
Fixes #6352.
    @hwillson
    hwillson committed May 29, 2020
    Configuration menu
    Copy the full SHA
    a7232bf View commit details
    Browse the repository at this point in the history

  2. Use String.prototype.split for CJS React munging.

    @benjamn
    benjamn committed May 29, 2020
    Configuration menu
    Copy the full SHA
    0b8845b View commit details
    Browse the repository at this point in the history